feat: discover shell login options from /etc/shells#97
Closed
Conversation
- Introduce `ShellsFile` package variable in `session/discovery.go`. - Add `discoverShellSessions()` to parse `/etc/shells` and extract executables. - Append extracted shells to the session menu as Type 'C' (Console). - Update unit tests and mock `ShellsFile` to cover the new functionality. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces shell session discovery by reading the /etc/shells file, allowing console logins to be listed as available sessions. The implementation includes a new discoverShellSessions method in the session package and updates to the test suite to mock and verify this behavior. Feedback was provided regarding the need to check for errors after the bufio.Scanner loop to ensure that no I/O issues occurred during the file reading process.
Comment on lines
+235
to
+250
| for scanner.Scan() { | ||
| line := strings.TrimSpace(scanner.Text()) | ||
| if line == "" || strings.HasPrefix(line, "#") { | ||
| continue | ||
| } | ||
|
|
||
| if _, err := d.ExecLookPath(line); err == nil { | ||
| name := filepath.Base(line) + " shell" | ||
| sessions = append(sessions, Session{ | ||
| Name: name, | ||
| Exec: line, | ||
| Type: "C", | ||
| Path: ShellsFile, | ||
| }) | ||
| } | ||
| } |
There was a problem hiding this comment.
The bufio.Scanner loop finishes without checking for errors. It is a best practice to check scanner.Err() after the loop to ensure that the file was read completely and no I/O errors occurred during scanning.
for scanner.Scan() {
line := strings.TrimSpace(scanner.Text())
if line == "" || strings.HasPrefix(line, "#") {
continue
}
if _, err := d.ExecLookPath(line); err == nil {
name := filepath.Base(line) + " shell"
sessions = append(sessions, Session{
Name: name,
Exec: line,
Type: "C",
Path: ShellsFile,
})
}
}
if err := scanner.Err(); err != nil {
return nil, err
}
Owner
Author
There was a problem hiding this comment.
The
bufio.Scannerloop finishes without checking for errors. It is a best practice to checkscanner.Err()after the loop to ensure that the file was read completely and no I/O errors occurred during scanning.for scanner.Scan() { line := strings.TrimSpace(scanner.Text()) if line == "" || strings.HasPrefix(line, "#") { continue } if _, err := d.ExecLookPath(line); err == nil { name := filepath.Base(line) + " shell" sessions = append(sessions, Session{ Name: name, Exec: line, Type: "C", Path: ShellsFile, }) } } if err := scanner.Err(); err != nil { return nil, err }
There was a problem hiding this comment.
Good point. I've added the error check using scanner.Err() after the bufio.Scanner loop in discoverShellSessions to catch any I/O errors that might occur during the file reading.
Owner
Author
|
@jules test failures please run and fix all tests: |
I have fixed the failing test |
Owner
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces the feature to parse
/etc/shellsand present them as shell login options with Type 'C' (Console). It dynamically maps and validates the executables from the file, providing users with traditional shell fallback choices.PR created automatically by Jules for task 12346225625501892072 started by @arran4