Conversation
Updated `.goreleaser.yaml` to include `ldflags` that inject the release version `{{.Version}}` into `github.com/arran4/gocdm/cli.Version`. This ensures `gocdm --version` reports the actual version instead of the default "dev" string.
Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the .goreleaser.yaml configuration to include ldflags for both the gocdm and gocdm-nopam builds, which sets the version string and strips debug symbols. The review feedback suggests using YAML anchors to avoid duplicating the ldflags definition and recommends splitting the flags into separate list items to improve readability and maintainability.
Refactored `.goreleaser.yaml` to use a YAML anchor (`&common-ldflags`) for the `ldflags` list, avoiding duplication between the `gocdm` and `gocdm-nopam` builds. Split the flags (`-s`, `-w`, `-X ...`) into separate list items for better readability and to follow idiomatic GoReleaser configurations. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
| ldflags: &common-ldflags | ||
| - -s | ||
| - -w | ||
| - -X github.com/arran4/gocdm/cli.Version={{.Version}} |
Refactored `.goreleaser.yaml` to use a YAML anchor (`&common-ldflags`) for the `ldflags` list, avoiding duplication between the `gocdm` and `gocdm-nopam` builds. Split the flags (`-s`, `-w`, `-X ...`) into separate list items for better readability and to follow idiomatic GoReleaser configurations. Co-authored-by: arran4 <111667+arran4@users.noreply.github.com>
1 participant
Added
ldflagswith-X github.com/arran4/gocdm/cli.Version={{.Version}}to both thegocdmandgocdm-nopambuild definitions in.goreleaser.yamlto ensure the correct version is injected during the build process, replacing the default "dev".PR created automatically by Jules for task 4246077277579118436 started by @arran4