Skip to content

Fix memory leak in SplitArray.Remove#10

Open
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
perf/fix-memory-leak-splitarray-5557648803222566373
Open

Fix memory leak in SplitArray.Remove#10
google-labs-jules[bot] wants to merge 1 commit into
mainfrom
perf/fix-memory-leak-splitarray-5557648803222566373

Conversation

@google-labs-jules
Copy link
Copy Markdown
Contributor

💡 What:

  • Updated SplitArray.Remove in spacepartition/spacemap.go to explicitly set unused elements in the backing array to nil before reslicing.
  • Added a regression test TestSplitArrayRemoveLeak in spacepartition/leak_test.go to verify the fix.
  • Added a benchmark BenchmarkSplitArrayRemove to monitor performance.

🎯 Why:

  • When removing elements from a slice by shifting, the elements at the end of the backing array (which are no longer part of the slice) still hold references to the objects. This prevents the Garbage Collector from reclaiming them, leading to a memory leak.
  • This change ensures those references are cleared, allowing memory to be freed.

📊 Measured Improvement:

  • Baseline: The reproduction test confirmed that references were retained (leak present).
  • After Fix: The regression test confirms that the tail element in the backing array is nil (leak fixed).
  • Performance: Benchmark showed negligible overhead (~10ns/op increase from 252ns to 263ns) for the safety gain.

PR created automatically by Jules for task 5557648803222566373 started by @arran4

- Nil out unused elements in the backing array after removal to allow GC.
- Add regression test and benchmark in spacepartition/leak_test.go.
@google-labs-jules
Copy link
Copy Markdown
Contributor Author

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@arran4 arran4 marked this pull request as ready for review January 20, 2026 01:54
Copy link
Copy Markdown
Owner

@arran4 arran4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant