Fix memory leak in SplitArray.Remove#10
Conversation
- Nil out unused elements in the backing array after removal to allow GC. - Add regression test and benchmark in spacepartition/leak_test.go.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
SplitArray.Removeinspacepartition/spacemap.goto explicitly set unused elements in the backing array tonilbefore reslicing.TestSplitArrayRemoveLeakinspacepartition/leak_test.goto verify the fix.BenchmarkSplitArrayRemoveto monitor performance.🎯 Why:
📊 Measured Improvement:
nil(leak fixed).PR created automatically by Jules for task 5557648803222566373 started by @arran4