⚡ Fix memory leak in PointArray.Remove#13
Conversation
- Zeros out the removed elements in the underlying array to allow GC. - Adds regression test and benchmark.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
💡 What:
PointArray.Removeafter the removal loop.TestPointArray_Remove_MemoryLeakto verify the fix.BenchmarkPointArray_Removeto track performance.🎯 Why:
Removeused a swap-and-reslice method but failed to clear the references in the unused portion of the underlying array. This prevented the Garbage Collector from reclaiming the memory used by the removedPointobjects, leading to a memory leak.📊 Measured Improvement:
Pointobjects can be garbage collected.PR created automatically by Jules for task 4155719814259340074 started by @arran4