⚡ Fix memory leak in ShapeArray.Remove#14
Conversation
- Set the element in the underlying array to nil after swapping/removing it from the slice. - Add regression test TestShapeArray_Remove_MemoryLeak.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
ShapeArray(and effectivelyStruct).ShapeArray.Removewould swap the element to remove with the tail element (or shift the window), but left the reference to the "removed" object in the underlying array's tail. This prevented the object from being garbage collected until the array itself was reallocated or collected.BenchmarkSpacePartitionAddDelete(which involves heavy add/remove).Structpersists and shapes are removed, preventing gradual heap growth. The short-lived benchmark doesn't capture this long-term retention.TestShapeArray_Remove_MemoryLeakwhich explicitly checks that the underlying array element is set tonilafter removal, confirming the fix.PR created automatically by Jules for task 13652935647002778501 started by @arran4