Skip to content

feat: question integration #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arran4 merged 2 commits into from
Jan 20, 2026
Merged

feat: question integration #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e7f9ac
fix: correct index from `minxi` to `minyi` when appending shapes to v…
arran4 Jan 19, 2026
34a5277
Refactor: Reformat imports, simplify variable declaration, and correc…
arran4 Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions space2trees/spacebtree.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
package space2trees

import (
"github.com/arran4/spacemap/shared"
"strconv"

"github.com/arran4/spacemap/shared"
)

type Type int
Expand Down Expand Up @@ -174,7 +175,7 @@ func (n *Node) AvlBalance(depth int) *Node {
}
_ = n.RecalculateDepth(depth)
nBal := n.Balance()
var cBal Balance = Balanced
var cBal = Balanced
switch nBal {
case Left:
cBal = n.Children[0].Balance()
Expand Down
7 changes: 4 additions & 3 deletions space2trees/spacebtree_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,12 @@ package space2trees
import (
"bytes"
"fmt"
"github.com/arran4/spacemap/shared"
"github.com/google/go-cmp/cmp"
"image"
"reflect"
"testing"

"github.com/arran4/spacemap/shared"
"github.com/google/go-cmp/cmp"
)

func NSMBalanced(shapes ...shared.Shape) func() *Struct {
Expand Down Expand Up @@ -1017,7 +1018,7 @@ func TestNode_InsertHere(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
tt.InsertHere(tt.ZIndex, tt.Shape, tt.Type)
if diff := cmp.Diff(tt.Node.Here, tt.Expected); diff != "" {
if diff := cmp.Diff(tt.Here, tt.Expected); diff != "" {
t.Errorf("Error mismatch with here and expected;\n%s", diff)
}
})
Expand Down
5 changes: 3 additions & 2 deletions spacepartition/spacemap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
package spacepartition

import (
"github.com/arran4/spacemap/shared"
"image"
"sort"

"github.com/arran4/spacemap/shared"
)

type Alignment int
Expand Down Expand Up @@ -177,7 +178,7 @@ func (m *Struct) Add(shape shared.Shape, zIndex int) {
}
maxyi++
} else {
m.VSplits[minxi].BecauseOf = append(m.VSplits[minxi].BecauseOf, shape)
m.VSplits[minyi].BecauseOf = append(m.VSplits[minyi].BecauseOf, shape)
}
if minxhs[0] != nil {
for _, vs := range m.VSplits {
Expand Down
Loading