Re-enable muted sliders when interacted with#144
Merged
Conversation
Owner
|
Hey @RoelN, this is fantastic, and in my testing, it is working great. The code changes seem pretty minimal and straightforward, too, which makes it easy to understand what changed. Thank you so much for finding such an elegant solution here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I got nerd-sniped into this one!
This PR enables muted sliders when clicked upon, setting the font into
[Custom axes]mode.I wasn't able to remove the
disabledattribute and move the handle to where the user clicked, so I opted to have faux disabled range sliders and simply remove this styling when the sliders are interacted with.In favor of #143