Repository navigation
feature: deploy v1.0.17 to main branch #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,12 +9,6 @@ | |
| import Foundation | ||
| import SwiftUI | ||
|
|
||
| // swiftlint:disable line_length | ||
| #if os(tvOS) | ||
| #warning("Votice SDK is currently only supported on iOS, iPadOS and macOS. Support for tvOS will be available in future releases.") | ||
| #endif | ||
| // swiftlint:enable line_length | ||
|
|
||
| // MARK: - Configuration | ||
|
|
||
| public struct Votice { | ||
|
|
@@ -118,35 +112,35 @@ extension Votice { | |
| /// Present the Votice feedback interface | ||
| /// - Parameters: | ||
| /// - theme: Custom theme for the UI (optional) | ||
| /// - minWidth: Minimum width for macOS (default 800) | ||
| /// - minHeight: Minimum height for macOS (default 600) | ||
| /// - width: width for macOS (default 800) | ||
| /// - height: height for macOS (default 600) | ||
|
Comment on lines
+115
to
+116
|
||
| /// - Returns: A SwiftUI View that can be presented modally or embedded | ||
| public static func feedbackNavigationView( | ||
| theme: VoticeTheme? = nil, | ||
| minWidth: CGFloat = 800, | ||
| minHeight: CGFloat = 600 | ||
| width: CGFloat = 800, | ||
| height: CGFloat = 600 | ||
| ) -> some View { | ||
| open(isNavigation: true, theme: theme, minWidth: minWidth, minHeight: minHeight) | ||
| open(isNavigation: true, theme: theme, width: width, height: height) | ||
| } | ||
|
|
||
| /// Present the Votice feedback interface as a standalone view | ||
| /// - Parameters: | ||
| /// - theme: Custom theme for the UI (optional) | ||
| /// - minWidth: Minimum width for macOS (default 800) | ||
| /// - minHeight: Minimum height for macOS (default 600) | ||
| /// - width: width for macOS (default 800) | ||
| /// - height: height for macOS (default 600) | ||
|
Comment on lines
+129
to
+130
|
||
| /// - Returns: A SwiftUI View that can be used in any context | ||
| /// - Note: This view is suitable for embedding in your app's UI or presenting as a full-screen cover | ||
| public static func feedbackView( | ||
| theme: VoticeTheme? = nil, | ||
| minWidth: CGFloat = 800, | ||
| minHeight: CGFloat = 600 | ||
| width: CGFloat = 800, | ||
| height: CGFloat = 600 | ||
| ) -> some View { | ||
| #if os(iOS) || os(macOS) | ||
| NavigationStack { | ||
| open(isNavigation: false, theme: theme, minWidth: minWidth, minHeight: minHeight) | ||
| open(isNavigation: false, theme: theme, width: width, height: height) | ||
| } | ||
| #elseif os(tvOS) | ||
| open(isNavigation: false, theme: theme, minWidth: minWidth, minHeight: minHeight) | ||
| open(isNavigation: false, theme: theme, width: width, height: height) | ||
| #endif | ||
| } | ||
| } | ||
|
|
@@ -165,11 +159,7 @@ extension Votice { | |
| surfaceColor: Color? = nil | ||
| ) -> VoticeTheme { | ||
| // Use smart defaults if no colors are provided | ||
| createAdvancedTheme( | ||
| primaryColor: primaryColor, | ||
| backgroundColor: backgroundColor, | ||
| surfaceColor: surfaceColor | ||
| ) | ||
| createAdvancedTheme(primaryColor: primaryColor, backgroundColor: backgroundColor, surfaceColor: surfaceColor) | ||
| } | ||
|
|
||
| /// Get a system theme that automatically adapts to the user's appearance preference | ||
|
|
@@ -387,13 +377,20 @@ private extension Votice { | |
| static func open( | ||
| isNavigation: Bool, | ||
| theme: VoticeTheme? = nil, | ||
| minWidth: CGFloat = 800, | ||
| minHeight: CGFloat = 600 | ||
| width: CGFloat = 800, | ||
| height: CGFloat = 600 | ||
| ) -> some View { | ||
| SuggestionListView(isNavigation: isNavigation) | ||
| let widthValue = max(width, 800) | ||
| let heightValue = max(height, 600) | ||
|
|
||
| return SuggestionListView(isNavigation: isNavigation) | ||
| .voticeTheme(theme ?? .default) | ||
| .task { | ||
| ConfigurationManager.shared.width = widthValue | ||
| ConfigurationManager.shared.height = heightValue | ||
| } | ||
| #if os(macOS) || os(tvOS) | ||
| .frame(minWidth: minWidth, minHeight: minHeight) | ||
| .frame(width: widthValue, height: heightValue) | ||
| #endif | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
widthandheightproperties are not declared in theConfigurationManagerProtocol. These properties should be added to the protocol to maintain proper abstraction and ensure any implementations of this protocol include these properties.