Ip block - #1
Open
artifactory wants to merge 36 commits into
Open
Conversation
Fix find_by_name for zones
…: resolve language inconsistencies with existing classes.
Removed byebug.
Removed byebug
update record content
…spec for :all for both dns_records and firewall_rules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for the forked version. Comment copied from base PR:
Added firewall rules.NOTE: in order to override the default 20 record limit, a pagination scheme is used that deviates from the dns_records model. afaict dns_records could utilize paging as well. This PR handles that for firewall_rules only; if the scheme is viable, or when an alternative scheme is implemented, it can be migrated to dns_records as well. If pagination is available in the original gem but I've just overlooked it, I'd suggest documentation.Another question is whether such methods as rule/record creation/deletion should be articulated methods in the gem, or just documented as leveraged resources. I left them out for now, but personally would be inclined to implement them within the gem.(I tried to restore the whitespace scheme of the original, but that was only partially successful, so there's a bunch of annoying whitespace diffs on blank lines.)