fix: respect -preserve-ns flag in processors#193
Open
girdharshubham wants to merge 2 commits intoarttor:mainfrom
Open
fix: respect -preserve-ns flag in processors#193girdharshubham wants to merge 2 commits intoarttor:mainfrom
girdharshubham wants to merge 2 commits intoarttor:mainfrom
Conversation
…ount processors Certificate and Issuer processors used hardcoded templates that never included the namespace field, even when -preserve-ns was set. Refactored both to use ProcessObjMeta for metadata generation, which already handles namespace preservation. Cert-manager hook annotations are injected onto the object before calling ProcessObjMeta when -cert-manager-as-subchart is enabled. ServiceAccount retains its custom template but now conditionally injects the namespace when -preserve-ns is set. Also fixed a pre-existing bug where Issuer processor was not passing values to issResult, causing webhook.enabled to be silently dropped. Fixes arttor#192
girdharshubham
changed the title
…leBinding with -preserve-ns
When -preserve-ns is set, keep the original namespace on binding subjects
instead of replacing it with {{ .Release.Namespace }}. This ensures
correct ServiceAccount references in umbrella chart deployments where
the release namespace differs from the target namespace.
girdharshubham
force-pushed
the
fix/preserve-ns-cert-issuer-sa
branch
from
8b6e706 to
9d6f48a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certificate and Issuer processors used hardcoded templates that never included the namespace field, even when -preserve-ns was set. Refactored both to use ProcessObjMeta for metadata generation, which already handles namespace preservation. Cert-manager hook annotations are injected onto the object before calling ProcessObjMeta when -cert-manager-as-subchart is enabled.
ServiceAccount retains its custom template but now conditionally injects the namespace when -preserve-ns is set.
RoleBinding and ClusterRoleBinding processors unconditionally replaced subject namespaces with {{ .Release.Namespace }}. With -preserve-ns, the original subject namespace is now preserved.
Also fixed a pre-existing bug where Issuer processor was not passing values to issResult, causing webhook.enabled to be silently dropped.
Fixes #192