Conversation
omohokcoj
force-pushed
the
master
branch
2 times, most recently
from
November 11, 2021 12:33
6d8aa16 to
f65f455
Compare
omohokcoj
force-pushed
the
master
branch
2 times, most recently
from
November 29, 2021 15:43
7f549df to
a211adf
Compare
omohokcoj
force-pushed
the
master
branch
2 times, most recently
from
December 21, 2021 17:45
38747bf to
6813988
Compare
omohokcoj
force-pushed
the
master
branch
5 times, most recently
from
December 29, 2021 19:11
7ea4acc to
1c625ab
Compare
Fix creation of records for Rails 7.2 version
…nerator-fails-with-error Fix motor generators for Rails 7.2
Fix: Adjust wrong number of arguments
…-files Fix: Move wrap_io_params callback setup from concern to controllers
fix: support symbol keys in ActiveRecord reflections
Rails 8.0 removed the reflection parameter from TableMetadata#initialize as part of Rails commit e8b3164fc973a576315a57ba29918d9e2b97a8da. This change dynamically detects the arity of TableMetadata#initialize and calls it with either 2 arguments (Rails 8.0+) or 3 arguments (Rails 7.x) to maintain compatibility across both versions. The reflection delegation was removed in Rails 8 because the reflection instance is already available where needed in the predicate builder, making the delegation through TableMetadata unnecessary. Reference: rails/rails@e8b3164 Changes: - Add build_table_metadata helper method with arity detection - Cache reflection support check for performance - Refactor duplicated builder creation code for better readability
Fix TableMetadata initialization for Rails 8 compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.