🛡️ Sentinel: [HIGH] Fix SSRF and missing input validation in AddExternalSource

[arumes31]

🚨 Severity: HIGH

💡 Vulnerability

The AddExternalSource endpoint in internal/api/excluded_handlers.go allowed unconstrained external URL string inputs. Without input length limits and proper URL pre-flight validation, this presented two significant risks:

1. SSRF (Server-Side Request Forgery): The backend system could be instructed to make requests to internal/local IP addresses or unsupported schemas.
2. CWE-400 (Uncontrolled Resource Consumption): Lack of string constraints allowed for arbitrarily large payloads in the database.

🎯 Impact

If exploited, an attacker could force the server to execute malicious internal requests or exhaust resources.

🔧 Fix

• Added missing input length constraints for Name (255), SourceType (255) and URL (2048) in AddExternalSource.
• Imported the internal security package and applied security.IsSafeURL to validate the user-supplied external source URL prior to persisting it.

✅ Verification

1. go test -short ./... confirms internal API logic and existing security rules are intact.
2. Verified length validation properly triggers 400 Bad Request prior to further processing.

---

PR created automatically by Jules for task 11155444255575943224 started by @arumes31

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: b4da0c11-48c6-4767-b1e6-382e7781a75c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/ssrf-external-source-11155444255575943224

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}