Skip to content

⚡ avoid string allocation in EeroTime null check#30

Merged
arvarik merged 1 commit into
mainfrom
perf-optimize-time-null-check-2445190990310005899
Mar 21, 2026
Merged

⚡ avoid string allocation in EeroTime null check#30
arvarik merged 1 commit into
mainfrom
perf-optimize-time-null-check-2445190990310005899

Conversation

@arvarik

@arvarik arvarik commented Mar 21, 2026

Copy link
Copy Markdown
Owner

💡 What: Replaced string(b) == "null" with bytes.Equal(b, []byte("null")) in EeroTime.UnmarshalJSON for explicit null value checking.
🎯 Why: Avoids a known performance pitfall of string allocation from byte slices. While modern Go compilers often optimize string(b) == "constant", bytes.Equal is more explicit and robust across different compiler versions and contexts.
📊 Measured Improvement: In micro-benchmarks, both approaches showed ~0.4 ns/op with 0 B/op and 0 allocs/op, indicating that the Go compiler successfully optimized the original string conversion. However, the change was implemented to adhere to the project's performance guidelines and prevent potential regressions in non-optimized contexts.


PR created automatically by Jules for task 2445190990310005899 started by @arvarik

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@arvarik
arvarik merged commit e1de2c9 into main Mar 21, 2026
1 check passed
@arvarik
arvarik deleted the perf-optimize-time-null-check-2445190990310005899 branch March 21, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant