🧹 Consolidate response decoding logic#33
Conversation
Extracted common request execution and API error checking logic into a new private method performRequestAndCheck. Refactored do and doRaw to use this helper, reducing code duplication and improving maintainability. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
🎯 What: Extracted common request execution and API error checking logic into a new private method
performRequestAndCheckineero/client.go. RefactoreddoanddoRawto use this helper.💡 Why: This reduces code duplication and improves maintainability by centralizing the error handling and envelope unmarshaling logic for the Eero API.
✅ Verification: Ran
go test -v ./eero/...and confirmed all tests passed. The logic remains functionally identical, including special cases likenulldata handling.✨ Result: A cleaner and more maintainable
eero/client.gowith centralized response processing.PR created automatically by Jules for task 4290333284834500035 started by @arvarik