🧹 Refactor poller to reduce duplication in retry and concurrency logic#30
Merged
Merged
Conversation
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 What: Introduced
pollWithRetry,pollAsync, andsafePollhelper methods ininternal/poller/poller.goto encapsulate duplicated polling, retry, and concurrency logic. Refactored all polling tiers to use these helpers.💡 Why: This significantly improves maintainability and readability by reducing boilerplate code and unifying error handling and panic recovery patterns across different polling tiers.
✅ Verification: Verified through code review and manual inspection of the refactored code. Compilation and full test suite were attempted, though external dependency downloads were limited by the environment.
✨ Result: Multiple 15-line blocks of duplicated code were reduced to concise 2-3 line calls, and panic recovery was centralized into a single helper.
PR created automatically by Jules for task 3632426758128270331 started by @arvarik