fix(security): resolve type confusion in query and body parameters#1596
Open
Abhishek2005-ard wants to merge 2 commits into
Open
fix(security): resolve type confusion in query and body parameters#1596Abhishek2005-ard wants to merge 2 commits into
Abhishek2005-ard wants to merge 2 commits into
Conversation
Contributor
Author
|
@aryandas2911 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves a Type Confusion vulnerability across several controllers that could lead to Application Crashes (Unhandled Exceptions). Previously, endpoints assumed that incoming request properties (like
password,email, andtitle) were strings. If an attacker supplied an array or object instead, executing string-specific methods like.test(),.trim(), or.toLowerCase()triggeredTypeErrorexceptions that crashed the server process or returned unhandled500 Server Errors.Changes Made
Added strict
typeof === "string"checks to validate payload types before executing string methods.authController.js:signup: Added type checks to ensurepasswordis a valid string.login: Validated thatemailandpasswordare strings before querying the database and verifying hashes.updateProfile: Enforced string types forname,currentPassword, andnewPassword.taskController.js:createTask: Added a strict type check to ensure thetitleparameter is a valid string before attempting to check its length or escape it.Testing Performed
{"email": ["test@test.com"]}) or objects safely returns a400 Bad Requestinstead of crashing the server.close #1568