Repository navigation
feat(reviewer): research provenance — footer, agy version, transcript archive - #172
Merged
Merged
Conversation
Probe agy --version once per tick (mtime-cached) and record it in the
posted review footer, dry-run artifacts/launch.json, research manifests,
and the tick log. Model labels alone do not catch silent agy upgrades.
Footer shape:
*{model} in [agy {cli_ver}]({agy_release_url}) took {dur} via [goobreview {ref}]({engine_url}).*
Clean agy versions link to antigravity-cli release notes; messy probes stay
plain text. When HEAD is exactly a v* release tag tip, the engine link points
at goobreview release notes instead of the raw commit. sync-worktree fetches
refs/tags/v* so detached VM checkouts can resolve that. The "in agy …" and
"via goobreview …" segments are omitted when unavailable.
Capture the brain session id and a gzipped transcript_full.jsonl next to each research arm (#157), before the counterfactual run overwrites the shared agy-runtime sidecars. Manifests record session_id and transcript_archive paths plus a fixed epistemic note that transcript thinking fields are model-paraphrased summaries, not verbatim reasoning. Oversize transcripts are truncated at REVIEWER_MAX_TRANSCRIPT_BYTES (default 10 MiB) with a sidecar marker. Missing transcripts remain best-effort (stdout_fallback / agy_failed paths).
Plant brain-session transcripts in the research-loop fixture so #157 is covered under a full tick: distinct posted/CF session ids, gzip archives on disk, and gunzip content. Keep a FIXTURE_NO_TRANSCRIPT path that still succeeds with stdout_fallback and null session/archive fields.
Agent and contributor docs state that shell validation targets Ubuntu/WSL, not Git Bash. The fixture runner exits non-zero without flock or on MSYS instead of soft-skipping. scripts/dev-env-check.sh is an optional read-only probe for the GNU tools the daemon and suite need. Note GNU sort/sed at the provenance footer call sites.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens review and research provenance so posted reviews and research pairs are comparable across silent CLI upgrades and engine revisions.
*{model} in [agy {cli_ver}](release) took {dur} via [goobreview {ref}](commit|release).*v*tag tip, else the commitsync-worktreefetchesrefs/tags/v*so detached VM checkouts can resolve release tipstranscript_full.jsonlper research arm (before counterfactual overwrites sidecars), epistemic note in the manifest, size cap with truncation markerFIXTURE_NO_TRANSCRIPTstdout_fallback pathscripts/dev-env-check.shTest plan
bash scripts/reviewer/tests/run-fixtures.shunder WSL Ubuntu — 617/617Closes #157