Remove dependence on cdb_make_free function…#1
Open
ludrao wants to merge 5 commits intoasb:masterfrom
Open
Conversation
… cdb_make_finish calls it anyway
Author
|
I mixed up the topic in the same master branch in my repo, so this pull request actually address 3 different issues:
|
Author
|
This PR fixes issue #2 |
|
Thank you folays for these commits. lua-tinycdb is working with lua5.2 with these changes. The only error I got with example.lua is: free(): invalid pointer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cdb_make_finish is a tinycdb private function so it is not exported. The public function cdb_make_finish calls it anyway.
This pull request helps using lcdb with a shared library without having to modify tinycdb code.