(engine) Confine rename writes to the corpus root - #426
Merged
Conversation
tcballard
force-pushed
the
codex/mcp-response-budgets
branch
from
August 2, 2026 18:23
8e92a96 to
523b563
Compare
tcballard
force-pushed
the
codex/engine-confine-rename-writes
branch
from
August 3, 2026 03:58
b4443d6 to
3f5c91e
Compare
tcballard
marked this pull request as ready for review
August 3, 2026 05:54
## Summary - make `decided rename --apply` transactional across the identity file and inbound references - preflight every affected file for containment, permissions, staleness, and rendered output before any replacement - stage rendered files as exclusive sibling files, commit via sibling backups, and roll back in reverse order on failure - document the recovery contract in ADR-130 and the CLI/port contract docs This is stacked on the root-confinement fix in #426 and closes #408. ## Validation - `cargo test --workspace` - `cargo clippy -p asdecided-core --all-targets -- -D warnings` - `cargo build --release --bin decided --bin decided-mcp` - live corpus: `decided validate decisions --json` — 449/449 checked, 0 invalid, OKF conformant - live corpus: `decided sentry decisions --full --json` — OK, no findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #407, stacked on the MCP hardening series.
O_NOFOLLOWfor the final-component race.symlink-pathandpath-outside-rootrefusal codes with clear dry-run paths.Validation
cargo test --workspacecargo test -p asdecided-core --test renamecargo clippy -p asdecided-core --all-targets -- -D warningsdecidedanddecided-mcpvalidatepassed; Sentry full-tree gate passed with ADR-129 constraints matchedCloses #407.