Skip to content

fix(a11y): restore section landmarks and skip-link focus in built output #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishbhateja wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(a11y): restore section landmarks and skip-link focus in built output #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,21 +89,21 @@ function page(manifest, css, script) {
<h1>The Call Beyond</h1>
<p class="tagline">${escapeHtml(manifest.edition ?? '')}</p>
</header>
<main id="main">
<section id="arc-section" class="panel"><h2 id="arc-heading">The 2026 arc</h2>
<main id="main" tabindex="-1">
<section id="arc-section" aria-labelledby="arc-heading" class="panel"><h2 id="arc-heading">The 2026 arc</h2>
<div id="arc-current" class="arc-current"></div>
<div id="arc-movements" class="arc-movements"></div>
<div id="arc-detail" class="arc-detail" role="region" aria-label="Selected month" hidden></div>
</section>
<section class="panel"><h2 id="interests-heading">Your interests</h2>
<section aria-labelledby="interests-heading" class="panel"><h2 id="interests-heading">Your interests</h2>
<div id="interests" class="chips" role="group" aria-labelledby="interests-heading"></div>
<button id="reset-profile" type="button" class="secondary">Clear my profile</button>
</section>
<section class="panel"><h2 id="search-heading">Search this edition</h2>
<section aria-labelledby="search-heading" class="panel"><h2 id="search-heading">Search this edition</h2>
<label class="visually-hidden" for="search">Search articles</label>
<input id="search" type="search" placeholder="Search…" autocomplete="off" />
</section>
<section class="panel"><h2>Reading list</h2>
<section aria-labelledby="recommendations-heading" class="panel"><h2 id="recommendations-heading">Reading list</h2>
<p id="results-heading" class="results-heading" aria-live="polite">Recommended for you</p>
<ul id="results" class="cards"></ul>
</section>
Expand Down
2 changes: 1 addition & 1 deletion src/reader/reader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ <h1>The Call Beyond</h1>
</p>
</header>

<main id="main">
<main id="main" tabindex="-1">
<section id="arc-section" aria-labelledby="arc-heading" class="panel">
<h2 id="arc-heading">The 2026 arc</h2>
<p class="hint">
Expand Down
Loading