Skip to content

a11y: search landmark, article aria-label, touch targets (#5) #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashishbhateja wants to merge 1 commit into
base: main
Choose a base branch
from
Open

a11y: search landmark, article aria-label, touch targets (#5) #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/reader/reader.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -366,7 +366,7 @@ button {
.link {
border: 0;
background: none;
padding: 0;
padding: 0.55rem 0; /* vertical padding brings tap target to ~44px (WCAG 2.5.5) */
color: var(--accent);
font: inherit;
font-weight: 600;
Expand Down
2 changes: 1 addition & 1 deletion src/reader/reader.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h2 id="interests-heading">Your interests</h2>
<button id="reset-profile" type="button" class="secondary">Clear my profile</button>
</section>

<section aria-labelledby="search-heading" class="panel">
<section role="search" aria-labelledby="search-heading" class="panel">
<h2 id="search-heading">Search this edition</h2>
<label class="visually-hidden" for="search">Search articles</label>
<input
Expand Down
2 changes: 2 additions & 0 deletions src/reader/reader.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,7 @@ function renderSearchResults(hits) {
function openArticle(article) {
personalizer.recordRead(article);
els.article.hidden = false;
els.article.setAttribute('aria-label', article.title);
els.article.replaceChildren();

const close = document.createElement('button');
Expand Down Expand Up @@ -315,6 +316,7 @@ function openArticle(article) {
function closeArticle() {
if (els.article.hidden) return;
els.article.hidden = true;
els.article.setAttribute('aria-label', 'Article');
els.article.replaceChildren();
els.resultsHeading.tabIndex = -1;
els.resultsHeading.focus();
Expand Down
Loading