Conversation
Owner
ashiven
commented
Aug 8, 2025
ashiven
commented
- Add an installer for windows to replace the slow onefile executable
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Windows installer using Inno Setup to replace the slow onefile PyInstaller executable, improving the user experience for Windows installations.
Key changes:
- Switched PyInstaller from
--onefileto--onedirmode for better performance - Added Inno Setup configuration file to create a proper Windows installer
- Updated the GitHub Actions workflow to build the installer and deploy it instead of a zip file
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| setup.iss | New Inno Setup configuration file defining installer properties, file sources, and installation behavior |
| .github/workflows/pyinstaller.yml | Modified workflow to use onedir mode, build Windows installer, and upload installer instead of zip file |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.