Skip to content

Feat/add tests infrastructure - #5

Draft
PureJoyMind wants to merge 4 commits into
ashkanRmk:devfrom
PureJoyMind:feat/add-tests-infrastructure
Draft

Feat/add tests infrastructure#5
PureJoyMind wants to merge 4 commits into
ashkanRmk:devfrom
PureJoyMind:feat/add-tests-infrastructure

Conversation

@PureJoyMind

@PureJoyMind PureJoyMind commented Sep 14, 2025

Copy link
Copy Markdown

Summary

This PR sets up the initial test infrastructure for FastCrud and introduces the first set of unit tests.

Linked issue: #4

Changes

  • Test infrastructure

    • Added test dependencies to Directory.Packages.props so test projects follow solution defined packages
    • Created a test folder in solution folder.
    • Used the naming convention "<ProjectName.Tests.TestType>". For example the unit test project for Core is named: "FastCrud.Core.Tests.Unit"
  • Test models & DTOs: Decided to use the Customer and Order models and their Dtos from the sample api project, but copied them and created TestCustomer etc.

Unit tests (currently - changes through time)

  • FastCrud.Core.Tests.Unit project covers CrudService<> type's methods. Each method has it's own test class.

Roadmap

  • Extend unit test coverage for other CRUD operations

Notes

  • Opened as a Draft PR to allow discussion on scope (unit tests only vs. integration tests included here) and while I keep adding tests until the requirements are satisfied

@ashkanRmk

Copy link
Copy Markdown
Owner

Thanks a lot for kicking this off! The structure and naming look good and aligns with what we discussed. I’ll go through the details and leave any review notes by the weekend. Feel free to keep pushing more unit tests in the meantime.

@ashkanRmk
ashkanRmk self-requested a review September 15, 2025 15:50
@ashkanRmk ashkanRmk added the enhancement New feature or request label Sep 15, 2025
@ashkanRmk

Copy link
Copy Markdown
Owner

Heads-up: I just pushed some updates to the dev branch (structural tweaks + minor service changes), so please pull/rebase from dev and resolve any merge conflicts before I start the review.

@PureJoyMind

PureJoyMind commented Sep 15, 2025

Copy link
Copy Markdown
Author

I'll fetch from dev and continue writing tests! Thanks for assigning me. We'll discuss any changes you'd like to me to make whenever you review the tests that I've written in the mean time and we'll be in touch.

@PureJoyMind
PureJoyMind force-pushed the feat/add-tests-infrastructure branch from 5fbc752 to dc878bb Compare September 15, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants