Refactor: Migrate monolithic HTML UI to native Web Components#154
Open
Adithyakp86 wants to merge 1 commit into
Open
Refactor: Migrate monolithic HTML UI to native Web Components#154Adithyakp86 wants to merge 1 commit into
Adithyakp86 wants to merge 1 commit into
Conversation
|
Someone is attempting to deploy a commit to the ashujsrfox's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Refactor]: Migrate Monolithic HTML UI to Native Web Components (Custom Elements)
📝 Description
This PR refactors the Weatherify user interface from a single, monolithic
index.htmlfile paired with global styles into a modern, component-driven architecture using native Web Components (Custom Elements) and Shadow DOM.This modernization adheres to the project's "Vanilla JS" philosophy while heavily improving maintainability, encapsulating styles to prevent CSS leakage, and cleaning up DOM bloat.
🎯 Objectives Completed
<weather-header>: Manages branding, language selection, theme toggling, and unit toggling.<weather-search>: Encapsulates the search bar, history dropdowns, and location tracking.<current-weather>: Handles the display of current weather conditions, including the main temperature card, sun track, and detailed metrics.<forecast-list>: Manages the hourly and daily forecast lists/charts.<weather-map>: Encapsulates the radar map view.style.css.script.jsapplication logic from direct DOM manipulation. Components now expose APIs (e.g.,setWeatherData(),setLoading()) and dispatch custom events (e.g.,search,theme-change,unit-change) for communication.index.htmlfile has been transformed into a clean, semantic, declarative structure.🏗️ Changes Made
public/components/weather-header.jspublic/components/weather-search.jspublic/components/current-weather.jspublic/components/forecast-list.jspublic/components/weather-map.jspublic/index.html(Replaced monolithic structure with custom tags)public/script.js(Updated core logic to use component APIs and custom events instead of directquerySelectorDOM manipulation)public/style.css(Cleaned up and moved component-specific styles out of global scope where applicable)🧪 Testing Performed
📸 Before & After
Before (
index.htmlexcerpt):