feat: add AI instruction bundle output - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #12.
Adds a generated instruction bundle for SkillMint with detected stacks, evidence, commands, next-step checks, safer output-path handling, manifest integrity metadata, verification checks, low-confidence detection review, and a machine-readable manifest for tooling.
This update extends the same PR with a dedicated AI instruction bundle review policy and a regression guard so generated bundle output has a clear human review path before CI, scripts, or AI agents consume it.
Issue review and prioritization
Open issues reviewed in
asimawdah/SkillMint:Changes
.ai/instructionsbundle generation withREADME.md,STACKS.md,COMMANDS.md,SAFE_CHANGES.md,NEXT_STEPS.md, andMANIFEST.json.--instructions-dirfor custom output folders.--instructions-dirstays inside the project root.--instructions-dirby rejecting ambiguous./..segments, control characters, project-root targets, and existing-file targets before dry-run planning or file writes.--instructions-dirvalues that resolve inside the project root while keeping manifest paths project-relative.MANIFEST.jsonwith summary metadata, role-path metadata, entrypoints, selected stack IDs, validation command summaries, and SHA-256 hashes for generated Markdown bundle files.low_confidence_threshold,low_confidence_stack_ids, andrequires_detection_reviewwhen a selected stack is below the confidence threshold.NEXT_STEPS.mddetection-confidence review guidance so weak detections are manually confirmed before broad automated edits.1.6while adding backward-compatible low-confidence review fields only when needed.verify_instruction_bundle(...)to check manifest presence, JSON validity, schema/bundle path consistency, expected file lists, entrypoints, files_by_role, integrity metadata, missing files, SHA-256 mismatches, malformed digest values, confidence value shape, and stale low-confidence summary flags.skillmint --verify-instructionswith success/failure exit codes for CI and scripted checks.docs/AI_INSTRUCTION_BUNDLE_REVIEW.mdwith required detection, validation, integrity, path-safety, and automation-consumption gates.tests/test_instruction_bundle_review_policy.pyto guard the review policy and prevent removal of safety-critical review language.README.mdanddocs/AI_INSTRUCTION_BUNDLE.mdwith verification commands, strict digest expectations, detection review guidance, and review workflow guidance.Verification
mainfromfeature/12-ai-skill-detector-instructions.bba59ddd54209cf92f47986ad60a2e6d8129033e.78commits ahead and0behindmain.main.CIrun28580726553completed successfully.Notes