Correct Modrinth game version coverage - #39
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b574b59b96
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "game_version_max_exclusive": "1.22", | ||
| "compatibility_label": "`1.20.6` and `1.21.x`", | ||
| "game_versions": [ | ||
| "1.20", |
There was a problem hiding this comment.
The repo still declares the runtime baseline as 1.20.6: pom.xml:33 says the jar is compiled against the oldest supported API, README.md:67 lists Minecraft 1.20.6-1.21.x, and the release smoke workflow only exercises the lower bound on Paper 1.20.6. With these new 1.20–1.20.5 tags, the Modrinth payload will publish the release to server versions outside the supported/evidenced range, so admins on those versions can install a jar that is only built and tested for 1.20.6+.
Useful? React with 👍 / 👎.
1 participant
What changed
1.20through1.20.6)1.21.111.21.12+,1.22+, and snapshots until compatibility is reviewedWhy
The first automation revision incorrectly started the Modrinth metadata at 1.20.6. Existing release metadata and the required public compatibility surface cover all 1.20.x versions plus 1.21.x through 1.21.11.
Validation
mvn -B -ntp clean verify— 93 tests, 38 P0 tests, JaCoCo and PIT passedpython scripts/check-release-security.pypython scripts/test-modrinth-release.py— 6 tests passedpython scripts/test-release-version.pyactionlint .github/workflows/*.yml