Conversation
| @override | ||
| def on_conversation_start(self, conversation: Conversation) -> None: | ||
| self._summary = UsageSummary() |
There was a problem hiding this comment.
This was resetting the Usage Summery?
| self._reporter.add_message( | ||
| role="Usage Tracker", | ||
| content=f"Usage for step {step_index}: {str(result.usage)}", | ||
| ) |
There was a problem hiding this comment.
Is this only for debugging?
There was a problem hiding this comment.
I think this should be removed, as the usage per step is already part of the html report anyways (we log the full message there, which has a "usage" field, see screenshot attached)
| def model_id(self) -> str: | ||
| return self._model_id_value | ||
|
|
||
| @property |
There was a problem hiding this comment.
This will lead to the html reports showing cost when using the askui API. This is something that we do not want as the cost for the users can be completely different when using our API (e.g. when they use free credits.
--> this needs to be removed again
There was a problem hiding this comment.
was used for debugging
yes, it should be removed
|
Thanks @mlikasam-askui for your quick fix with the usage tracking!! I integrated this fix here and the usage tracking refactorings from your improve-token-consumption branch into this PR here: #253 Hence, I would recommend to close this PR here. You agree? |
|
Implemented in #253 |
3 participants
No description provided.