-
Notifications
You must be signed in to change notification settings - Fork 58
refactor: make office docs optional and reduce core dependency footprint #255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,7 @@ | ||
| import time | ||
| import uuid | ||
| from typing import Any | ||
|
|
||
| import bson | ||
| from pydantic import Field | ||
|
|
||
|
|
||
|
|
@@ -14,7 +15,9 @@ def generate_time_ordered_id(prefix: str) -> str: | |
| str: Time-ordered ID string | ||
| """ | ||
|
|
||
| return f"{prefix}_{str(bson.ObjectId())}" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I do not know what bson was doing and what effects removing it has. Out of curiosity: can you maybe explain?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It was the reason why the SDK was not compatible with Python 3.14 and later, but now the imagehash library is the new issue causing incompatibility. |
||
| timestamp_hex = f"{time.time_ns():x}" | ||
| random_hex = uuid.uuid4().hex[:12] | ||
| return f"{prefix}_{timestamp_hex}{random_hex}" | ||
|
|
||
|
|
||
| def IdField(prefix: str) -> Any: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is android no longer part of the all group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah I see, because it is now a default, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it’s included by default, and we should start using
pip install askuiwithout the all option, especially on Windows, to improve installation speed.