Apply governance overlay, add governance checks and fix validation issues#1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
governance:check/release:preflight) without changing plugin identity (ADR-0002).Description
.github/templates and workflows,docs/(ADR, architecture, security, testing, release, repo-settings),AGENTS.mdvariants,CHANGELOG.md,CODEOWNERS,CONTRIBUTING.md, and helper scripts underscripts/(check-readme-disclosures.mjs,check-release-assets.mjs,check-version-sync.mjs).package.json(version bump to1.0.5,validate,governance:check,release:preflight,ciscript variants) and updatedpackage-lock.jsonaccordingly.toArrayBufferhelper and converting binaryBufferusage toArrayBufferforcreateBinary/modifyBinary, adjustedLocalIndexerand baseline typings to acceptTFileand includesize, and expanded conflict reason typing to include safety case.arrayBufferto mocked responses, assertedrequestUrlparam shape, addedctimetoFakeTFile.stat, and fixed globalwindowsetup), and relaxed / stabilized ESLint config to a working baseline in the environment sonpm run lintis executable without unavailable dev dependencies.obsidian-github-api-sync-governance-overlay.zip) after successful application.Testing
npm cisuccessfully to install dependencies.npm run governance:check(which runsvalidateand the README disclosure check) and it succeeded.npm run typecheckandnpm run lintand both completed successfully after the minimal fixes to types and the ESLint config.npm testand all tests passed (9 test files, 43 tests total).npm run buildandnpm run release:preflightand both completed with the release-asset and version-sync checks passing.All automated validation commands above passed in this environment.
Codex Task