Make process name also match bundle name and bundle id#399
Open
einhund wants to merge 1 commit intoasmvik:masterfrom
Open
Make process name also match bundle name and bundle id#399einhund wants to merge 1 commit intoasmvik:masterfrom
einhund wants to merge 1 commit intoasmvik:masterfrom
Conversation
| static inline char * | ||
| find_process_bundle_id_for_psn(ProcessSerialNumber *psn) | ||
| { | ||
| CFDictionaryRef process_info_ref = ProcessInformationCopyDictionary(psn, kProcessDictionaryIncludeAllInformationMask); |
There was a problem hiding this comment.
Do we assume this call will never return NULL?
Author
There was a problem hiding this comment.
Not according to my tests and I can't find any documentation since it's long deprecated. But I'll add checks just to be sure.
| { | ||
| CFDictionaryRef process_info_ref = ProcessInformationCopyDictionary(psn, kProcessDictionaryIncludeAllInformationMask); | ||
| CFStringRef process_bundle_id_ref = CFDictionaryGetValue(process_info_ref, kCFBundleIdentifierKey); | ||
| char *process_bundle_id = copy_cfstring(process_bundle_id_ref); |
There was a problem hiding this comment.
Copy_cfstring_to_cstring will cause memory leak if it fails.
How are we ensuring it will not return NULL and dereference?
Author
There was a problem hiding this comment.
Good point. Added checks for null value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useful for precise matching with bundle id, and generic matching with bundle name. Ex:
"Web App"matches all web apps added to Dock from Safari.Full example:
I didn't read the full codebase of this project. Thorough code review would be needed.