test(e2e): move the pycross suites into an isolated e2e/crossbuild workspace - #1431
Merged
Merged
Conversation
…rkspace The rules_pycross ports (pycross-distutils-probe, pycross-patches, pycross-pure-python, pycross-setuptools) landed in e2e/cases, but they are sdist-crossbuild suites: their hubs carry package-specific overrides (default_build_dependencies, pre/post-install patches, resource_set) that shouldn't share a module with unrelated cases, and the cross-compilation test matrix will grow around them. Give them their own e2e/crossbuild workspace with a minimal MODULE.bazel (rules_py via local_path_override, bazel_lib for collect_wheels, the LLVM toolchain for the native sdist builds, PBS interpreters 3.12/3.13, uv). The wheel-collection tooling (collect_wheels.bzl/.py, check_wheel_tags.py) moves along with them: pycross-pure-python was its last consumer under e2e/cases. The linux_x86_64 platform and the assert_* helpers stay, they still have consumers there. CI gets the new workspace in the test matrix and in the macOS smoke job, which previously covered these suites through e2e/cases.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
✨ Aspect Workflows Tasks📅 Thu Aug 13 22:28:13 UTC 2026 ✅ 44 successful tasks
⏱ Last updated Thu Aug 13 22:33:44 UTC 2026 · 📊 GitHub API quota 1,322/15,000 (9% used, resets in 41m) |
py_binary startup benchmark
sys.path quality
Bazel analysis benchmark
|
xangcastle
enabled auto-merge (squash)
August 13, 2026 22:48
jbedard
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for the upcoming cross-compilation support, split out to slim down #1363.
The rules_pycross ports (
pycross-distutils-probe,pycross-patches,pycross-pure-python,pycross-setuptools) landed ine2e/cases, but they aresdist-crossbuild suites: their hubs carry package-specific overrides
(
default_build_dependencies, pre/post-install patches,resource_set) thatshouldn't share a module with unrelated cases. This PR moves them into their own
e2e/crossbuildworkspace — a minimalMODULE.bazel(rules_py vialocal_path_override,bazel_lib, the LLVM toolchain, PBS interpreters3.12/3.13, uv) — which is where the cross-build test matrix from #1363 will land
next.
Everything moves as pure renames; the wheel-collection tooling
(
collect_wheels,check_wheel_tags) comes along sincepycross-pure-pythonwas its last consumer under
e2e/cases. CI gets the new workspace in the testmatrix and the macOS smoke job, which previously covered these suites through
e2e/cases. No rule code changes.🤖 Generated with Claude Code