-
-
Notifications
You must be signed in to change notification settings - Fork 98
feat: add pyc compilation of first-party python code via actions #1506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
c789055
ed8f20b
0561046
b2b5c54
e312809
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -61,5 +61,6 @@ check_coverage //coverage-drivers:coverage_pytest_test bazel-testlogs/coverage-d | |
| check_coverage //coverage-drivers:coverage_pytest_codegen_test bazel-testlogs/coverage-drivers/coverage_pytest_codegen_test/coverage.dat | ||
| check_coverage //coverage-drivers:coverage_pytest_chdir_test bazel-testlogs/coverage-drivers/coverage_pytest_chdir_test/coverage.dat | ||
| check_coverage //coverage-drivers:coverage_unittest_test bazel-testlogs/coverage-drivers/coverage_unittest_test/coverage.dat | ||
| check_coverage //coverage-drivers:coverage_pyc_only_test bazel-testlogs/coverage-drivers/coverage_pyc_only_test/coverage.dat | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. [P3] Check that the new coverage regression actually records a hit for -zbarskybot |
||
|
|
||
| echo "All coverage driver checks passed." | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P2] Benchmark the bytecode modes before drawing performance conclusions. The published analysis, startup, and image jobs never set the new
pycflag or attribute, so all three run the defaultsourcemode. They do not measure enabled compile cost, startup benefit, worker versus non-worker execution, or the new bytecode image traversal. Please benchmarksource,pyc, andpyc_onlyon an import-heavy first-party graph, including cold builds and a one-source incremental rebuild; include the non-worker strategy rather than assuming the local worker represents remote execution. Published benchmark results.-zbarskybot