Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (14)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughChangesTransitive Python type stub propagation
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to This change propagates Python type-stub metadata through providers and virtualenv integration without identified merge-blocking risk. Sequence Diagram(s)sequenceDiagram
participant rules_python_library
participant py_library
participant PyInfo
participant pyi_propagation_test
rules_python_library->>py_library: Provide library.pyi through rules_python PyInfo
py_library->>PyInfo: Publish transitive_pyi_files
PyInfo->>pyi_propagation_test: Expose propagated library.pyi
pyi_propagation_test-->>py_library: Assert .pyi propagation and empty sources
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 13.64% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 22 functions across 13 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@mkanat how can we test this? Checkout the existing |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d612b530a3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Thanks @mkanat. I picked up your commit as-is (authorship kept) in #1538 and built the rest on top: |
|
Okay, thanks! Sorry I wasn't able to respond in time here, just been really busy. |
This is the most conservative change possible to make protobuf pyi files (which use rules_python underneath) propagate correctly (see my comment in #558). I could have made all the rules_py rules support putting pyi files in srcs, or made a new pyi_srcs, but I didn't want to propose a new API right now, so this seemed safer.
I did not just slop this PR out, I did review everything and have done multiple refinements to it on top of Codex's output. However, I'm not deeply familiar with all of the rules_py codebase so it's possible some of this isn't structured ideally.