-
-
Notifications
You must be signed in to change notification settings - Fork 98
docs: document minimum python versions #1543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+20
−4
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -137,6 +137,20 @@ Built-in rules for creating optimized container images: | |
| bazel_dep(name = "aspect_rules_py", version = "1.11.2") | ||
| ``` | ||
|
|
||
| ### Requirements | ||
|
|
||
| The minimum supported Python version is **3.10**. The launcher, test runners, and build | ||
| tools that run under your configured interpreter use 3.10 syntax, and CI only exercises | ||
| 3.10 and newer. Older interpreters can still be fetched via `interpreters.configure()`, | ||
| but `py_binary` and `py_test` targets will fail at startup on them. | ||
|
|
||
| Some `uv` features need newer versions: | ||
|
|
||
| | Feature | Python | | ||
| | ----------------------------------------------------------------------------------------------------------------------- | ------ | | ||
| | Free-threaded interpreters (`freethreaded = True`), [first shipped in CPython 3.13](https://peps.python.org/pep-0703/) | 3.13+ | | ||
| | `pyproject.toml` parsing in sdist native-dependency detection (needs stdlib `tomllib`) | 3.11+ | | ||
|
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possibly we'll want to change this to allow 3.10 but lets just stick with it and document it for now. |
||
|
|
||
| ### Quick Start | ||
|
|
||
| Load rules from `aspect_rules_py` in your `BUILD` files: | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a fetched pre-3.10 interpreter and a compatible user entry point, generic
py_binaryandpy_testtargets do not load the 3.10-only test runners:py/private/py_venv/py_venv_exec.bzlconstructs a native launcher that directly executes the venv interpreter with the user'smain(lines 94-118). Such targets can therefore start successfully; the syntax restriction applies to specific maintained helpers such as the pytest/unittest runners and build tools. Describe older interpreters as unsupported, or scope the startup-failure statement to targets that actually execute those helpers.Useful? React with 👍 / 👎.