Skip to content

fix(py): make merged pip layer outputs unique per binary - #1549

Open
dzbarsky wants to merge 2 commits into
aspect-build:mainfrom
dzbarsky:upstream/merged-pip-layer-outputs
Open

dzbarsky wants to merge 2 commits into
aspect-build:mainfrom
dzbarsky:upstream/merged-pip-layer-outputs

Conversation

@dzbarsky

Copy link
Copy Markdown
Collaborator

Two binaries in one package can use the same wheel group with different dependencies. Their merge aspects currently declare the same archive, causing Bazel to report conflicting actions. Include the binary target name in the merged archive's directory so each binary retains its own wheel set.

Validation: a new analysis test reproduces the conflict before the fix and passes afterward. The existing merged-layer compression test, buildifier, and git diff --check also pass.

@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 070d2822-873e-4907-b3ba-76042c320a27

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant