Open
Conversation
* it seems to me that moving from the procedural setup.py to the declarative setup.cfg is a nice compromise between modernization and compatibility with legacy systems * pkg_resources are dead, we should not use them, the suggested construct has as The Single Source of Truth™ version in git_deps/__init__.py and it should work anywhere with setuptools >= 46.4.0, which is reasonably ancient * six should really never be mentioned any more
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.pyto the declarativesetup.cfgis a nice compromise between modernization and compatibility with legacy systemspkg_resourcesare dead, we should not use them, the suggested construct has as The Single Source of Truth™ version ingit_deps/__init__.py, and it should work anywhere withsetuptools>= 46.4.0, which is reasonably ancientsixshould really never be mentioned any more