Desktop: handle denied Keychain access during safeStorage decrypt without crash-report path#16
Draft
Copilot wants to merge 3 commits into
Draft
Desktop: handle denied Keychain access during safeStorage decrypt without crash-report path#16Copilot wants to merge 3 commits into
safeStorage decrypt without crash-report path#16Copilot wants to merge 3 commits into
Conversation
Agent-Logs-Url: https://github.com/asrient/HomeCloud/sessions/49c9aee8-0458-4f35-b98e-68515ea920c6 Co-authored-by: asrient <44570278+asrient@users.noreply.github.com>
Agent-Logs-Url: https://github.com/asrient/HomeCloud/sessions/49c9aee8-0458-4f35-b98e-68515ea920c6 Co-authored-by: asrient <44570278+asrient@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix crash report error while decrypting ciphertext in safeStorage
Desktop: handle denied Keychain access during Apr 15, 2026
safeStorage decrypt without crash-report path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Startup could fail with
safeStorage.decryptString(“Decryption is not available”) when macOS Keychain access is denied at launch. This path currently surfaces as a crash report instead of a targeted user-facing recovery message.Keychain-denied error classification
KeychainAccessDeniedErrorindesktop/src/app.ts.safeStorage.encryptString/decryptStringcalls with a small classifier that maps keychain-unavailable conditions to this explicit error type.Startup failure handling
initAppstartup error handling to interceptKeychainAccessDeniedError.Keychain access is required) with actionable guidance (allow HomeCloud in system keychain/security settings, then restart), then exits cleanly.Security/identity behavior preserved