Skip to content

Handle missing terminfo fallbacks and restore unicode test#10

Open
assisted-by-ai wants to merge 1 commit intomasterfrom
codex/review-changes-since-tag-49.5-1-2
Open

Handle missing terminfo fallbacks and restore unicode test#10
assisted-by-ai wants to merge 1 commit intomasterfrom
codex/review-changes-since-tag-49.5-1-2

Conversation

@assisted-by-ai
Copy link
Copy Markdown
Owner

Summary

  • restore the unicode test hard failure when the trojan-source checkout is absent
  • add TERM-based fallbacks for get_sgr_support so stdisplay handles missing terminfo entries without spurious failures

Testing

  • ./run-tests (fails: pylint not available in environment)

Codex Task

@assisted-by-ai
Copy link
Copy Markdown
Owner Author

Added TERM-aware fallbacks in get_sgr_support so stdisplay handles missing terminfo entries gracefully while still enforcing conservative color support where appropriate.

@ArrayBolt3
Copy link
Copy Markdown

Rejected. The heuristics are really not a good idea IMO. We have terminfo, if terminfo is broken falling back to no color is safest. If the user really wants color support despite their broken or otherwise unsupported setup, they can export COLORTERM=truecolor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants