Handle missing terminfo fallbacks and restore unicode test#10
Open
assisted-by-ai wants to merge 1 commit intomasterfrom
Open
Handle missing terminfo fallbacks and restore unicode test#10assisted-by-ai wants to merge 1 commit intomasterfrom
assisted-by-ai wants to merge 1 commit intomasterfrom
Conversation
Owner
Author
|
Added TERM-aware fallbacks in get_sgr_support so stdisplay handles missing terminfo entries gracefully while still enforcing conservative color support where appropriate. |
|
Rejected. The heuristics are really not a good idea IMO. We have terminfo, if terminfo is broken falling back to no color is safest. If the user really wants color support despite their broken or otherwise unsupported setup, they can export |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_sgr_supportso stdisplay handles missing terminfo entries without spurious failuresTesting
pylintnot available in environment)Codex Task