Skip to content

Handle missing executable name in append-shared#3

Open
assisted-by-ai wants to merge 1 commit intomasterfrom
codex/find-bugs-in-scripts
Open

Handle missing executable name in append-shared#3
assisted-by-ai wants to merge 1 commit intomasterfrom
codex/find-bugs-in-scripts

Conversation

@assisted-by-ai
Copy link
Copy Markdown
Owner

Summary

  • avoid IndexError in append-shared when invoked without a mode by safely deriving the executable name
  • fall back to the script name if the mode argument is missing

Testing

  • python3 usr/libexec/helper-scripts/append-shared append /tmp/testappend foo

Codex Task

@ArrayBolt3
Copy link
Copy Markdown

The idea here is good, but the implementation is not. We should be warning the user and exiting if someone tries to call append-shared directly. Will implement a different approach to this.

@ArrayBolt3
Copy link
Copy Markdown

Implemented: ArrayBolt3@3e071fd

@assisted-by-ai
Copy link
Copy Markdown
Owner Author

Added a safe executable-name helper in append-shared to prevent IndexError when the script is invoked without a mode argument, falling back to the script name as needed.

@ArrayBolt3
Copy link
Copy Markdown

Partially accepted and implemented as described above. This PR can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants