feat: introduce generic multi-architecture paging/address-space model - #710
Open
DID-Lab-SZU wants to merge 10 commits into
Open
DID-Lab-SZU wants to merge 10 commits into
DID-Lab-SZU wants to merge 10 commits into
Conversation
rikosellic
reviewed
Aug 20, 2026
| /// A physical address that can identify a base-page frame for architecture `A`. | ||
| pub open spec fn valid_frame_paddr_for<A: ArchPagingModel>(pa: Paddr) -> bool { | ||
| pa % A::C::BASE_PAGE_SIZE() == 0 && pa < A::max_paddr_spec() | ||
| } |
Collaborator
There was a problem hiding this comment.
@Marsman1996 Shall we replace all the original valid_frame_paddr with this new definition?
Collaborator
There was a problem hiding this comment.
I think we should, since the original valid_frame_paddr is only for x86 arch 🤔
Collaborator
There was a problem hiding this comment.
It seems they update the valid_frame_paddr to call this valid_frame_paddr_for now.
rikosellic
reviewed
Aug 20, 2026
| pub open spec fn paddr_to_vaddr_for<A: ArchAddressSpaceModel>(pa: Paddr) -> Vaddr { | ||
| (pa + A::linear_mapping_base_vaddr_spec()) as usize | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Like above, shall we replace all the original paddr_to_vaddr_spec (i.e., paddr_to_vaddr in spec mode ) with this new definition?
Je5s1e
force-pushed
the
feat/arch-paging-model
branch
from
August 21, 2026 09:35
fc8e683 to
65c41b5
Compare
Collaborator
|
Why we cannot call the copilot now 😣 |
Collaborator
|
This PR seems to have some overlap with the ongoing #675. I prefer to finish that first. |
Je5s1e
force-pushed
the
feat/arch-paging-model
branch
from
September 8, 2026 03:03
23d9881 to
f158f4b
Compare
Integrate asterinas/vostd main at e3c7e11, including the fractional metadata permission refactor and Rust 1.98.1 update. Preserve the architecture paging model and its generic address proofs while resolving overlapping proof and import changes. Keep page-table node destruction aligned with the upstream implementation and permission interfaces. Isolate Segment::from_unused in a spinoff prover to resolve the resource-limit failure without changing its contracts or executable body. Validation: make (1523 verified, 0 errors); cargo dv focus --targets ostd -- --verify-only-module mm::frame::segment; cargo dv fmt --paths on resolved files; git diff --check.
Marsman1996
requested changes
Sep 9, 2026
Collaborator
|
Please merge the latest main first, there is some change in lemma names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.