Addressing test failures under SIPp v 3.7.5. certified 18.9 #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test failures largely fell under one of three categories: Overall timeout. SIPp 3.7.5 enforces an overall scenario execution timeout. These tests had their timeout manually set in the associated yaml file. 3pcc termination. Some tests were exiting prematurely because the partner scenario terminated. These tests were modified to include an end sendcmd/recvcmd to coordinate the termination. IPV6 'target' flag was set incorrectly. A number of tests had the 'target' flag set within the key-args dict within the associated yaml. These tests had the 'target' flag moved outside of the key-args. These tests were working with earlier versions of SIPp because those versions used the last target positional arg while 3.7.5 fails if more than one target positional arg is specified. Fixes: asterisk#107
Contributor
Author
|
cherry-pick-to: none |
mbradeen
changed the title
gtjoseph
approved these changes
Oct 8, 2025
github-actions
bot
added
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Attention! This pull request may contain issues that could prevent it from being accepted. Please review the checklist below and take the recommended action. If you believe any of these are not applicable, just add a comment and let us know.
- The PR title does not match the commit title. This can cause confusion for reviewers and future maintainers. GitHub doesn't automatically update the PR title when you update the commit message so if you've updated the commit with a force-push, please update the PR title to match the new commit message body.
Documentation:
|
Workflow PRCheck completed successfully |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-tests-passed
recheckpr
pr-submit-testing-in-progress
labels
|
Workflow PRCheck completed successfully |
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch certified/18.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test failures largely fell under one of three categories:
Overall timeout. SIPp 3.7.5 enforces an overall scenario execution
timeout. These tests had their timeout manually set in the associated
yaml file.
3pcc termination. Some tests were exiting prematurely because the
partner scenario terminated. These tests were modified to include an
end sendcmd/recvcmd to coordinate the termination.
IPV6 'target' flag was set incorrectly. A number of tests had the
'target' flag set within the key-args dict within the associated yaml.
These tests had the 'target' flag moved outside of the key-args. These
tests were working with earlier versions of SIPp because those
versions used the last target positional arg while 3.7.5 fails if more
than one target positional arg is specified.
Fixes: #107