caller_local_blonde: wait for referee termination before sending BYE #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of waiting for the referee to finish after sending BYE, wait for the referee to finish then send the BYE. This avoids a potential race condition of receiving the termination cmd before sending the BYE, which breaks the referer scenario.
Contributor
Author
|
cherry-pick-to: 18 |
github-actions
bot
added
pr-submit-testing-in-progress
pr-submit-tests-passed
and removed
pr-submit-testing-in-progress
labels
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Workflow PRCheck completed successfully |
github-actions
bot
added
cherry-pick-testing-in-progress
|
Workflow PRCPCheck completed successfully |
github-actions
bot
added
pre-merge-testing-in-progress
pre-merge-checks-passed
merge-in-progress
and removed
merge-approved
pre-merge-testing-in-progress
labels
|
Successfully merged to branch master and cherry-picked to ["18","20","21","22","23","certified/18.9","certified/20.7"] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of waiting for the referee to finish after sending BYE, wait for the
referee to finish then send the BYE. This avoids a potential race condition
of receiving the termination cmd before sending the BYE, which breaks the
referer scenario.