chore(engine): pin 0.23.0, sync adopted extensions - #17
Merged
Conversation
…tensions Pins learn-content-engine to 0.23.0. The relevant change for this repo is Exercise.explanation (schema 1.13, additive): an optional Markdown "why" shown after the learner answers, regardless of correct or incorrect, distinct from hint (on-demand, before answering) and examples (worked examples shown before answering). 0.23.0 also ships three new reference extensions (ext:ref-audio-choice, ext:ref-audio-tiles, ext:ref-speak-and-record); this repo does not use them, so they do not touch validate_with_engine.mjs. While syncing, scripts/validate_with_engine.mjs's hardcoded ADOPTED_EXTENSIONS array turned out to list only 4 of the 9 ext: types the app actually supports (ext:al-categorization, ext:al-error-correction, ext:al-reading-comprehension, ext:al-graded-quiz) - missing ext:al-dictation, ext:al-image-description, ext:al-speak-and-record, ext:al-audio-choice, ext:al-audio-tiles. Same gap already found and fixed in astrapi69/alc-dog-training; not introduced by this repin, fixed here too. List now mirrors adaptive-learner's SUPPORTED_EXTENSIONS verbatim. Proof, via this repo's own runner at the new pin: - check_schema_drift.py: mirror in sync with 0.23.0 (no drift) - validate_with_engine.mjs --self-test: all 9 bad-lesson/extension/warning classes pass - engine-validate: 18 lessons + 3 manifests checked, 0 errors - engine-validate --warnings: same 18/3, 0 errors, 19 pre-existing W-CARD-UNUSED/W-TILES-DUP warnings, unrelated to this repin - check-stable-ids --base origin/main: 315 base id(s) / 315 head id(s), 18 base lesson(s) / 18 head lesson(s) - unchanged - check-stable-id-coverage: 2 of 2 set(s) fully minted, baseline 2 - audit_content.py: 18 lessons across 2 sets, no quality issues Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16.
Pins learn-content-engine to 0.23.0 (was 0.20.0) and refreshes the vendored schema mirror. The relevant change for this repo is
Exercise.explanation(schema 1.13, additive): an optional Markdown "why" shown after the learner answers, regardless of correct or incorrect, distinct fromhint(on-demand, before answering) andexamples(worked examples shown before answering). 0.23.0 also ships three new reference extensions (ext:ref-audio-choice,ext:ref-audio-tiles,ext:ref-speak-and-record); this repo does not use them.While syncing,
scripts/validate_with_engine.mjs's hardcodedADOPTED_EXTENSIONSarray turned out to list only 4 of the 9ext:types the app actually supports (ext:al-categorization,ext:al-error-correction,ext:al-reading-comprehension,ext:al-graded-quiz) - missingext:al-dictation,ext:al-image-description,ext:al-speak-and-record,ext:al-audio-choice,ext:al-audio-tiles. Same gap already found and fixed in astrapi69/alc-dog-training; not introduced by this repin, fixed here too. List now mirrors adaptive-learner'sSUPPORTED_EXTENSIONSverbatim.Gate results (this repo's own runner, at the new pin)
check_schema_drift.py: mirror in sync with 0.23.0 (no drift)validate_with_engine.mjs --self-test: all 9 bad-lesson/extension/warning classes passengine-validate: 18 lessons + 3 manifests checked, 0 errorsengine-validate --warnings: same 18/3, 0 errors, 19 pre-existing W-CARD-UNUSED/W-TILES-DUP warnings, unrelated to this repincheck-stable-ids --base origin/main: 315 base id(s) / 315 head id(s), 18 base lesson(s) / 18 head lesson(s) - unchangedcheck-stable-id-coverage: 2 of 2 set(s) fully minted, baseline 2audit_content.py: 18 lessons across 2 sets, no quality issues