Accept NumPy integer smoothing widths#1336
Draft
sapunyangkut wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The four smoothing entry points each limited valid widths to the built-in
intandfloattypes. Values produced by APIs such asnp.arange, includingnp.int64, are real numbers accepted by the downstream Astropy and SciPy operations but failed those duplicated checks.Using the standard-library
numbers.Realprotocol fixes the common type gate without accepting complex values.Validation
tox -e codestyle: passed, 0 errorsspecutils/tests/test_smoothing.py: 28 passedThe standard Python 3.13 tox command encountered a Windows permission error while finalizing pytest's cache. I reran the same installed environment and full test scope with the cache plugin disabled and
MPLBACKEND=agg; all tests passed as reported above.AI assistance
This fix was prepared with OpenAI Codex-assisted automation. I reviewed and understand the complete diff, reproduced the failure before the fix, ran the validation above, and take responsibility for the correctness and licensing of the contribution.
Fixes #1224.