Skip to content

Conversation

@Siddhi-sahu
Copy link

@Siddhi-sahu Siddhi-sahu commented Jan 5, 2026

Description
hopefully fixes #1829

I am new here, and still trying to understand the codebase.
I have opened the pr but I am not entirely sure if I am going into the right direction. Any little push would be appreciated.

Thank you for your time.
@Shurtu-gal
Related issue(s)

Signed-off-by: Siddhi sahu <himanisahu739@gmail.com>
@changeset-bot
Copy link

changeset-bot bot commented Jan 5, 2026

⚠️ No Changeset found

Latest commit: add3d66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Varadraj75
Copy link
Contributor

Hi @Siddhi-sahu,

I reviewed the PR and tested it locally.

Looks good

  • --compile flag is implemented correctly (default true, allowNo: true)
  • Flag is properly wired into GeneratorOptions
  • Verified locally that --compile and --no-compile appear and work as expected
  • Generator version is already 3.0.1, so the requirement is satisfied

Pending

  • Add integration tests in test/integration/generate/fromTemplate.test.ts:

    • default behavior
    • --no-compile / --compile=false
  • Add a changeset (npx changeset, minor bump for @asyncapi/cli)

  • Please confirm whether changes to entrypoint.sh and package-lock.json are intentional

Overall, the implementation looks solid. Let me know if you need any help with the tests or changeset.

@AayushSaini101
Copy link
Collaborator

/u

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 8, 2026

@Shurtu-gal
Copy link
Collaborator

Please add options accordingly here https://github.com/asyncapi/cli/blob/master/src/apps/cli/internal/base/BaseGeneratorCommand.ts#L47

I don't the compile option right now does anything meaningful till it's passed to generator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: To Triage

Development

Successfully merging this pull request may close these issues.

Enable --compile for generate fromTemplate command

5 participants