Conversation
- Add test for signal:true defaulting to SIGUSR2 - Add test for error when output.path is undefined - Add tests for restartable keyboard 'rs' restart - Add test for multiple assets logging - Add test for keyboard option defaults - Add test for worker without pid edge case Coverage improved: 83% -> 98% statements, 100% functions/lines
- Multiple assets test: now verifies correct asset selection - NODE_ENV defaults: split into 2 tests (dev/prod) with real assertions - Worker without pid: explicit no-throw and no-hang assertions - Add production NODE_ENV test for keyboard default
Owner
Author
|
A bit impatient, gonna merge this now and start implementing the fix for #56 |
|
I will take a look a bit later |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.