Add TypedClient sample apps and fix client naming and Asp.Versioning imports - #64
Merged
davidkallesen merged 3 commits intoAug 18, 2026
Merged
Conversation
davidkallesen
deleted the
feature/missing-operationid-in-typedclient-support
branch
August 18, 2026 12:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two TypedClient generation defects and adds runnable console apps that
demonstrate how to consume the generated clients.
Generator fixes:
Client class naming
The generated client type name was derived from the full project name, so a
dotted name such as "Eloverblik.Api.ThirdPartyApi" produced an invalid
identifier. HttpClientExtractor and ApiClientGenerator now use
CasingHelper.GetLastNameSegment(projectName), yielding "ThirdPartyApiClient".
Asp.Versioning using import
UsingStatementHelper matched the bare "ApiVersion" token, so ordinary
client-side member access such as "parameters.ApiVersion" pulled in the
server-only Asp.Versioning namespace and broke the build. The mapping now
keys on the construction shape "new ApiVersion(" instead.
Both fixes are covered by new tests in HttpClientExtractorTests and
UsingStatementHelperTests.
Samples:
and added the EloverblikThirdPartyApiClient TypedClient sample.
modes, showing host setup, IHttpClientFactory registration and the generated
API surface. Authentication is handled by a BearerTokenProvider singleton
read by a BearerTokenHandler on each request, since IHttpClientFactory pools
handlers and Eloverblik exchanges a refresh token for a short-lived access
token mid-session.
resolves per-operation endpoint interfaces from DI via the generated
AddEloverblikApiThirdPartyApiEndpoints() and returns result wrappers with
IsOk/IsUnauthorized branches, while TypedClient registers a single
ThirdPartyApiClient typed client whose methods return payloads directly and
throw HttpRequestException on non-success.