Add support to expose ports when running locally with Docker#573
Open
bobvandevijver wants to merge 1 commit intoathombv:developfrom
Open
Add support to expose ports when running locally with Docker#573bobvandevijver wants to merge 1 commit intoathombv:developfrom
bobvandevijver wants to merge 1 commit intoathombv:developfrom
Conversation
bobvandevijver
force-pushed
the
docker-ports
branch
from
d84ee90 to
459f11f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes you need to run a local server to receive updates from devices. For example, Shelly uses this to get updates pushed from devices directly to a CoAP or WS listener on Homey.
When running with docker, these listeners are running inside the docker container and currently not exposed, so impossible to access. This PR add the option to configure the exposed ports by docker, making it accessible on your host. Depending on your setup you might still need to configure your firewall and you should make sure that your machine IP is configured on the devices instead of the IP of the Homey (so, have a wrapper to resolve the actual IP of the device where the app is running instead of only relying on
homey.cloud.getLocalAddress(), as is done here).Note that using network host isn't a solution as that doesn't work for Windows, and I keep rebasing this small addition to be able to run the Shelly app.