Fixes to IPP in Grid.php and Grid-demo.#2315
Open
rickyosser wants to merge 2 commits into
Open
Conversation
…d so Grid ipp will show selected value if set, otherwise fallback to 50 as it is default.
…IPP in grid.feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 50 to items list both in the Grid-demo as well as in Grid.
Fixed so Grid ipp will show selected value if set, otherwise fallback to 50 as it is default.
If $ipp is 0 don't set $this->ipp to the first item as that always sets the viewed selection
to the first item in the list. If we actually track the ipp in the app we want it to set and
show the correct value, as it was before reload or other events, before this change it only set the selected ipp value but showed the first item.
Default ipp in this class is 50, that will be showed when nothing is selected.
If we want to have 10 as default, $ipp should be set to 10 instead of 50.