Skip to content

Conversation

@rinconjc
Copy link

@rinconjc rinconjc commented Jun 2, 2022

Artifactory secrets are being deprecated.

Please review and merge this change to use the new artifact publish token.

@rinconjc rinconjc requested a review from a team as a code owner June 2, 2022 05:16
@pczuj
Copy link
Contributor

pczuj commented Jun 22, 2022

A flaky test failed. I diagnosed it to some extent and commented in #13 (comment) (PR which introduced the test).

Didn't find any issue about it, so I created one: https://ecosystem.atlassian.net/browse/JPERF-811

@pczuj
Copy link
Contributor

pczuj commented Jun 22, 2022

From my understanding the failed test is not connected to the PR 🤞, so I will rerun it attempting to unblock the merge. Hopefully won't need to do that many times.

@pczuj pczuj merged commit 1ce2d7c into atlassian:master Jun 23, 2022
@pczuj
Copy link
Contributor

pczuj commented Jun 23, 2022

Released 2.4.3 after this change. Everything worked ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants